Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve persistence action commits #9923

Closed
Tracked by #8742
mattsse opened this issue Jul 31, 2024 · 0 comments · Fixed by #9929
Closed
Tracked by #8742

Improve persistence action commits #9923

mattsse opened this issue Jul 31, 2024 · 0 comments · Fixed by #9929
Assignees
Labels
C-debt Refactor of code section that is hard to understand or maintain

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 31, 2024

all db actions should be atomic and use a single commit

// first write to static files
self.write_execution_data(&blocks).expect("todo: handle errors");
// then write to db
self.write(&blocks).expect("todo: handle errors");

TODO

  • we need to apply all db changes and only commit once
  • each action should have it's own write function
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants