New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only persist the canonical chain #9897

Closed

Tracked by

mattsse opened this issue Jul 30, 2024 · 0 comments · Fixed by #9908

Closed

Tracked by

Only persist the canonical chain #9897

mattsse opened this issue Jul 30, 2024 · 0 comments · Fixed by #9908

Assignees

Labels

C-bug

Collaborator

mattsse commented Jul 30, 2024 •

edited

Loading

this check currently selects all blocks, including uncle blocks

reth/crates/engine/tree/src/tree/mod.rs

Lines 739 to 744 in 3a088a9

    
           self.state 
        
               .tree_state 
        
               .blocks_by_number 
        
               .range(start..end) 
        
               .flat_map(|(_, blocks)| blocks.iter().cloned()) 
        
               .collect()

TODO

This should select the canonical chain from the canonical head back to the last persisted block

mattsse mentioned this issue

Tracking: Engine revamp #8742

Closed

mattsse added the C-bug label

mattsse assigned fgimenez

fgimenez mentioned this issue

fix: only persist the canonical chain #9908

Merged

mattsse closed this as completed in #9908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment