Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace generic stateprovider with boxed trait #9777

Closed
Tracked by #8742
mattsse opened this issue Jul 24, 2024 · 0 comments · Fixed by #9780
Closed
Tracked by #8742

replace generic stateprovider with boxed trait #9777

mattsse opened this issue Jul 24, 2024 · 0 comments · Fixed by #9780
Assignees
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 24, 2024

this is currently generic over stateprovider

/// Historical state provider for state lookups that are not found in in-memory blocks.
historical: H,

but only useful if useful if the generic is state provider:

) -> ProviderResult<MemoryOverlayStateProvider<Box<dyn StateProvider>>> {

since our state_by_hash functions return Box<dyn StateProvider> anyway

image

we can simplify generics here and simply use Box

@mattsse mattsse changed the title replace generic stateprovider with bix replace generic stateprovider with boxed trait Jul 24, 2024
@mattsse mattsse added the C-enhancement New feature or request label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants