Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Ethservice into stream #9582

Closed
Tracked by #8742
mattsse opened this issue Jul 17, 2024 · 7 comments · Fixed by #9622
Closed
Tracked by #8742

Convert Ethservice into stream #9582

mattsse opened this issue Jul 17, 2024 · 7 comments · Fixed by #9622
Assignees
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 17, 2024

Currently we're ignoring internal events:

impl<DB, Client> Future for EthService<DB, Client>
where
DB: Database + 'static,
Client: HeadersClient + BodiesClient + Clone + Unpin + 'static,
{
type Output = Result<(), EthServiceError>;
fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
// Call poll on the inner orchestrator.
let mut orchestrator = self.project().orchestrator;
loop {
match ready!(StreamExt::poll_next_unpin(&mut orchestrator, cx)) {
Some(_event) => continue,

however some events can be useful for node event handling

blocked by #9575

TODO

  • convert this into a stream that bubbles up the event
@mattsse mattsse added the C-enhancement New feature or request label Jul 17, 2024
@mvares
Copy link
Contributor

mvares commented Jul 17, 2024

Hey @mattsse! #9575 has already been merged. Is this issue still blocked?

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 17, 2024

hey @mvares this is unblocked now but we need this pr pretty soon, if you have the bandwidth for it please go ahead

@mvares
Copy link
Contributor

mvares commented Jul 18, 2024

@mattsse, should I drop the impl Future?

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 18, 2024

yes

@mvares mvares removed their assignment Jul 18, 2024
@mvares
Copy link
Contributor

mvares commented Jul 18, 2024

@mattsse, sorry about that. Right now, I haven't sufficient skills to this task. I'll try take other task more easy.

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 18, 2024

all good!
if you dont find anything, please ping me on tg @mattsse

@junderw
Copy link
Contributor

junderw commented Jul 18, 2024

Please let me know what "bubbles up" means in this context. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants