Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate and handle errors in database and static file services #9535

Closed
Tracked by #8742
Rjected opened this issue Jul 15, 2024 · 2 comments
Closed
Tracked by #8742

Propagate and handle errors in database and static file services #9535

Rjected opened this issue Jul 15, 2024 · 2 comments
Labels
A-db Related to the database A-static-files Related to static files C-enhancement New feature or request S-stale This issue/PR is stale and will close with no further activity

Comments

@Rjected
Copy link
Member

Rjected commented Jul 15, 2024

Some of the static file service and database service methods have error return values, although they do not get propagated and probably need to be handled.

See:

.expect("todo: handle errors");

So, we will need to check the failure modes which would cause these errors, and either handle or propagate them.

@Rjected Rjected added C-enhancement New feature or request A-db Related to the database A-static-files Related to static files labels Jul 15, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Aug 6, 2024
@Rjected
Copy link
Member Author

Rjected commented Aug 6, 2024

Done

@Rjected Rjected closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database A-static-files Related to static files C-enhancement New feature or request S-stale This issue/PR is stale and will close with no further activity
Projects
Archived in project
Development

No branches or pull requests

1 participant