Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple vmtrace compatibility issues #4071

Closed
6 of 7 tasks
banteg opened this issue Aug 4, 2023 · 4 comments
Closed
6 of 7 tasks

multiple vmtrace compatibility issues #4071

banteg opened this issue Aug 4, 2023 · 4 comments
Assignees
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@banteg
Copy link

banteg commented Aug 4, 2023

Describe the bug

these are findings from a brief comparison with erigon. note that erigon's tracing routines are not free from bugs either.

  • op is missing
  • idx is missing
  • mem values are missing
  • used should track the remaining gas, currently it's equal to cost in reth
  • push on stack currently uses full words, while in other clients you'd see 0xc0ffeebabe rather than 0x000000000000000000000000000000000000000000000000000000c0ffeebabe
  • code has an extra zero word at the end for some reason

Steps to reproduce

trace_replayTransaction with reth and erigon and diff the output

Node logs

No response

Platform(s)

Linux (x86)

What version/commit are you on?

0.1.0-alpha.4

What database version are you on?

No response

If you've built Reth from source, provide the full command you used

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@banteg banteg added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels Aug 4, 2023
@Rjected Rjected added A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Aug 4, 2023
@mattsse
Copy link
Collaborator

mattsse commented Aug 5, 2023

there are like 0 docs for all these things so not surprising that things are missing.

The missing fields weren't part of the original OE impl.

what does idx represent here? "idx": "168-2" the last value appears to be the instruction idx, not sure what the leading value is

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Aug 25, 2023
@mattsse mattsse added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Aug 25, 2023
@onbjerg
Copy link
Member

onbjerg commented Apr 2, 2024

@mattsse Is this resolved via the linked PRs? Going through it seems like it?

@mattsse
Copy link
Collaborator

mattsse commented Apr 3, 2024

closing this, if there are still issues we track them separately once they get reported

@mattsse mattsse closed this as completed Apr 3, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Archived in project
Development

No branches or pull requests

4 participants