Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic receipt ExecuteOutput #12945

Open
Tracked by #12358
emhane opened this issue Nov 28, 2024 · 1 comment · May be fixed by #12966
Open
Tracked by #12358

Generic receipt ExecuteOutput #12945

emhane opened this issue Nov 28, 2024 · 1 comment · May be fixed by #12966
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started

Comments

@emhane
Copy link
Member

emhane commented Nov 28, 2024

Describe the feature

Make ExecuteOutput generic over receipt type as ExecuteOutput<T>

reth/crates/evm/src/execute.rs

Lines 175 to 182 in 4724564

/// Helper type for the output of executing a block.
#[derive(Debug, Clone)]
pub struct ExecuteOutput {
/// Receipts obtained after executing a block.
pub receipts: Vec<Receipt>,
/// Cumulative gas used in the block execution.
pub gas_used: u64,
}

Additional context

No response
@emhane emhane added A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started labels Nov 28, 2024
@emhane emhane mentioned this issue Nov 28, 2024
Open
@ftupas
Copy link
Contributor

ftupas commented Nov 28, 2024

Hi may I take this one?

@hoank101 hoank101 linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: generic receipt ExecuteOutput hoank101/reth
2 participants
@ftupas @emhane