Return result from TransactionCompat::fill

[emhane]

Describe the feature

Add AT TransactionCompat::Error and change signature of TransactionCompat::fill to return a result wrapping TransactionCompat::Error in error variant.

reth/crates/rpc/rpc-types-compat/src/transaction/mod.rs

Lines 78 to 80 in 7a06298

	/// Create a new rpc transaction result for a _pending_ signed transaction, setting block
	/// environment related fields to `None`.
	fn fill(&self, tx: TransactionSignedEcRecovered, tx_inf: TransactionInfo) -> Self::Transaction;

This error should then be propagated, instead of converting to option here

reth/crates/optimism/rpc/src/eth/transaction.rs

Line 115 in d7f08cd

.ok() // todo: change sig to return result

Additional context

No response

[Gerson2102]

Hey can I work on it?

[Gerson2102]

@emhane can you bring me some guidance here? I dont get where are you taking the TransactionCompat::fill there is nothing about that in the code. I dont get it.

[Gerson2102]

There is the signature of the function. But I dont know what do you want me to do with that, maybe change what we are returning?