Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jedi language server complain python 3.10 syntax #187

Closed
kasfil opened this issue Dec 14, 2021 · 4 comments · Fixed by #239
Closed

jedi language server complain python 3.10 syntax #187

kasfil opened this issue Dec 14, 2021 · 4 comments · Fixed by #239

Comments

@kasfil
Copy link

kasfil commented Dec 14, 2021

I have jedi_language_server installed trough pipx and python 3.10
but jedi complaining about new python match syntax
Screenshot from 2021-12-14 17-51-13

did i miss some configuration?

@pappasam
Copy link
Owner

@kasfil nope, you're not missing anything! Sadly, it looks like pattern matching syntax isn't yet supported by Jedi.

Until that's resolved upstream, I recommend disabling jedi diagnostics if you're relying on the new pattern matching syntax.

@davidhalter
Copy link

@pappasam A small update here, since this repo is probably the biggest (and only big) user of the "syntax errors" feature of Jedi.

At the moment it looks like that Python 10 syntax won't be supported for a while. This mostly won't really matter for autocompletion, goto renames, etc. I feel like we should seriously discuss just not having diagnostics in jedi-language-server, because it will likely not receive the amount of maintenance for now.

I already have a solution ready for this problem in my Rust rewrite of Jedi, but that will take a few years until it finalizes.

@pappasam
Copy link
Owner

@davidhalter given jedi-language-server's purpose, you're the boss! If you say syntax checking is not supported by (the Python version of) Jedi, then this project should not support it either.

When I get a moment, I'll remove jedi-language-server support for diagnostics entirely and create a new release. Users can still get diagnostics errors through https://github.com/iamcco/diagnostic-languageserver

@davidhalter
Copy link

@pappasam Thanks a lot! I feel like that's the most reasonable choice for now. You could also put it behind a feature flag or something similar. It kind of makes me a bit sad, given the amount of work that went into this feature, but the amount of work that goes into this is just too big for now...

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants