Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment path does not begin with / #16

Closed
Bluefitdev opened this issue Oct 19, 2020 · 5 comments · Fixed by #17
Closed

Deployment path does not begin with / #16

Bluefitdev opened this issue Oct 19, 2020 · 5 comments · Fixed by #17

Comments

@Bluefitdev
Copy link

Is anyone having this issue?

It never happened to me prior. I'm using laravel 8, it was fine on 7 before (i also upgraded the dotenv versioning)

❯ envoy run init

In Envoyca58753152131a6f645fe0e2e835f55f.php line 31:

  Careful - your deployment path does not begin with /
@davidrushton
Copy link
Member

@Bluefitdev If you're using the .env variable approach, have you set the DEPLOY_PATH variable (https://github.com/papertank/envoy-deploy#config) and can you share what you've set that to?

That exception is thrown by https://github.com/papertank/envoy-deploy/blob/master/Envoy.blade.php#L17 as a little guard to make sure you've set an absolute path to the deploy directory, avoiding it from messing up your folder structure from the SSH user home directory.

@robertwt7
Copy link

Yeah i know, weirdly it shows me empty path

currently set to

DEPLOY_PATH=/var/www/vhosts/example.com/

Even when I edit line 17 at Envoy.blade.php to echo $path, it returns empty

@davidrushton
Copy link
Member

Ah right. I've also reproduced this on a fresh L8 project using a Homestead VM. Looking into a fix - let me know if you get there first...

@davidrushton
Copy link
Member

Got it and added a PR - #17 . Would you be able to try those changes on your end and confirm that works okay now on Laravel 8? Thanks.

@davidrushton davidrushton linked a pull request Oct 21, 2020 that will close this issue
@robertwt7
Copy link

Its all working now, thanks mate! Appreciate it. love the work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants