Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private notes in Slack integration #560

Closed
Twixes opened this issue Feb 1, 2021 · 4 comments
Closed

Support private notes in Slack integration #560

Twixes opened this issue Feb 1, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Twixes
Copy link

Twixes commented Feb 1, 2021

Problem
Private notes added in #521 are great – they are however not sendable from the Slack integration, nor are they viewable there.

Solution
There should be an explicit way to send a private note from Slack (e.g. the message is considered a note when if it begins with a slash), and when a private note is sent from somewhere else (i.e. the web app), it should in turn be displayed in the Slack thread.

Additional context
A use case which would make this specifically useful is mentioning teammates (other agents) inside Slack, e.g. for assistance, without notifying the customer.

Testing
Not sure how you test the Slack integration, but basically sending a message with in Slack and verifying that it is then saved as a note (and NOT as a reply) in Papercups would cover this end-to-end.

@Twixes Twixes added the enhancement New feature or request label Feb 1, 2021
@reichert621
Copy link
Collaborator

@Twixes I did a little research into this, and it looks like Slack doesn't support slash commands in reply threads for some reason 😞 (see "Limitations on use" in https://api.slack.com/interactivity/slash-commands#enabling-interactivity-with-slash-commands__what-are-slash-commands)

So I'm thinking there are a couple alternatives to how we can handle this:

  1. Any messages that @mentions the Papercups app/bot is considered a note
  2. Any message that starts with [note] or 🔒 or ;; or some other agreed upon string/emoji is considered a note
  3. Something else?

Curious to hear your thoughts/preference

@Twixes
Copy link
Author

Twixes commented Feb 2, 2021

I think 1. could occasionally backfire if someone wants to do this intentionally in a normal reply. 2. sounds pretty good, just that the prefix should be simple to enter (definitely not an emoji) and practically never used in an online conversation/support cases at the start of the message. I was thinking a backslash would work well.

@reichert621
Copy link
Collaborator

backslash sounds good for now 👍

@reichert621
Copy link
Collaborator

done in #562!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants