Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaperTrail 11.0.0 is not compatible with ActiveRecord 6.1.0 #1272

Closed
sedubois opened this issue Dec 9, 2020 · 3 comments
Closed

PaperTrail 11.0.0 is not compatible with ActiveRecord 6.1.0 #1272

sedubois opened this issue Dec 9, 2020 · 3 comments

Comments

@sedubois
Copy link
Contributor

sedubois commented Dec 9, 2020

Is your feature suggestion related to a problem? Please describe.

PaperTrail is currently untested against Rails 6.1.0 and emits a warning on startup:

      PaperTrail 11.0.0 is not compatible with ActiveRecord 6.1.0. We allow PT
      contributors to install incompatible versions of ActiveRecord, and this
      warning can be silenced with an environment variable, but this is a bad
      idea for normal use. Please install a compatible version of ActiveRecord
      instead (>= 5.2, < 6.1). Please see the discussion in paper_trail/compatibility.rb
      for details.

Describe the solution you'd like to build

  • add ActiveRecord 6.1.0 to .travis.yml
  • fix any observed incompatibilities
  • update ACTIVERECORD_LT in lib/paper_trail/compatibility.rb

Describe alternatives you've considered

Ignore the warning. No regressions observed thus far.

@jaredbeck
Copy link
Member

Describe the solution you'd like to build

    add ActiveRecord 6.1.0 to .travis.yml
    fix any observed incompatibilities
    update ACTIVERECORD_LT in lib/paper_trail/compatibility.rb

Perfect! You got it, go for it! 👍

@pedrofurtado
Copy link

🎉

@jaredbeck
Copy link
Member

Closing via #1275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants