Adding explanation for clockTolerance on JWTVerifyOptions #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding explanation for clockTolerance on JWTVerifyOptions
|
Hello Daniel, thank you for this added explanation. Can you resubmit this PR from a non-default branch on your fork so that I may fix it up? |
wparad
reviewed
Nov 5, 2024
| @@ -38,6 +38,9 @@ Expected clock tolerance | |||
| - In seconds when number (e.g. 5) | |||
| - Parsed as seconds when a string (e.g. "5 seconds", "10 minutes", "2 hours"). | |||
There was a problem hiding this comment.
Can I say, I don't understand how it can be parsed in "seconds" when the input is "10 minutes". Does it mean that human readable formats will be parsed, or that "10 minutes" will be converted to 10 seconds...
There was a problem hiding this comment.
10 minutes is 600, 10 seconds is 10
|
Closing this PR: replaced by #732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a little confused about what the
clockToleranceoption did but the docs didn't help much, so I read the code. Here's a very minor improvement based on what I found.