Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull down a previously-bootstrapped rust engine binary during development #8716

Open
cosmicexplorer opened this issue Nov 26, 2019 · 1 comment
Assignees

Comments

@cosmicexplorer
Copy link
Contributor

It would be nice to not have to recompile rust every time we pull master, especially if it's a change to the rust version or something which causes all dependent packages to be recompiled. Since we already build and upload the native engine binary in our CI bootstrap shards, it seems reasonable that we could expose that to the outside world in a way that would allow us to pull down the native engine upon any change to master, and only compile it ourself if we're trying to modify rust code.

This approach is somewhat similar to mozilla's "source" and "binary" mode when checking out the mozilla repo, see the --enable-artifact-builds option description in https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build/Linux_and_MacOS_build_preparation.

@thejcannon
Copy link
Member

Hello 4-year old issue 😄

We're closer than ever to doing this:

shell_command(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants