Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider caching travis_ci/Dockerfile builds in CI #7072

Closed
cosmicexplorer opened this issue Jan 13, 2019 · 1 comment
Closed

consider caching travis_ci/Dockerfile builds in CI #7072

cosmicexplorer opened this issue Jan 13, 2019 · 1 comment

Comments

@cosmicexplorer
Copy link
Contributor

When working on #7064, we added python 3.6.8 to the centos6 base image via pyenv. This was great and the right thing to do (otherwise CentOS makes it quite hard to have multiple versions of python available, which is something we want for the base image). However, it was described to me that building build-support/docker/travis_ci/ can actually take some nontrivial period of time (just building the image itself, before we even start building pants). From a really quick investigation, it seems like it might be possible to cache the docker builds on travis (see especially the second link), but I'm not familiar enough with docker or travis's implementation to know whether there are roadblocks I'm missing.

Some other inspiration for this came from #7065, which allows locally iterating on the CentOS6 image, but that's a bit of a dual problem.

@Eric-Arellano
Copy link
Contributor

I don't think this would make a ton of sense because it increases the complexity of an already very complex CI. We already host our Docker images in Dockerhub.

The cost is only when you build a Docker image locally, and when you do that you'll benefit from Docker's caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants