Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVX-2643] Add new header x-pantheon-terminus-environment. #2613

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

kporras07
Copy link
Contributor

@kporras07 kporras07 commented Aug 5, 2024

OS and OSTYPE weren't getting any value in PHP in my tests. I haven't tested the other suggested var WSL_DISTRO_NAME because I don't have a WSL handy but I would expect a similar result so I went with the constant PHP_OS to (partially?) fulfill this need

Tested in CI by running with SSH on a random project and cloning repo, etc...

@kporras07 kporras07 marked this pull request as ready for review August 5, 2024 21:32
@kporras07 kporras07 requested a review from a team as a code owner August 5, 2024 21:32
@kporras07 kporras07 merged commit 1694a79 into 3.x Aug 7, 2024
10 checks passed
@kporras07 kporras07 deleted the devx-2643 branch August 7, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants