[LOPS-2313] Provide a trace id when calling remote commands #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alynnferry
changed the title
stovak
approved these changes
May 28, 2024
|
LGTM when the tests pass. |
greg-1-anderson
requested changes
May 29, 2024
kporras07
approved these changes
May 30, 2024
namespacebrian
approved these changes
May 30, 2024
added 2 commits
May 30, 2024 13:29
kporras07
approved these changes
May 30, 2024
greg-1-anderson
requested changes
May 31, 2024
|
|
||
| $ssh_data = $this->sendCommandViaSsh($command_line); | ||
| // Separate the command line and environment variables | ||
| list($command_line, $env_vars) = $this->getCommandLine($command_args, $env_vars); |
There was a problem hiding this comment.
Don't need to return $env_vars, since they are passed in.
There was a problem hiding this comment.
This still isn't resolved, and getCommandLine does not include $env_vars at the beginning of the line
greg-1-anderson
approved these changes
Jun 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Screen.Recording.2024-05-29.at.10.48.02.AM.mov