Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOPS-2119 - Wait for a healthcheck before releasing the command #2564

Merged
merged 11 commits into from
Apr 9, 2024

Conversation

stovak
Copy link
Member

@stovak stovak commented Apr 3, 2024

Tested with a local build against production PAPI. Seems to satisfy done-whens.

@stovak stovak requested a review from a team as a code owner April 3, 2024 17:33
@stovak stovak changed the title Wait for a healthcheck before releasing the command LOPS-2119 - Wait for a healthcheck before releasing the command Apr 3, 2024
@stovak
Copy link
Member Author

stovak commented Apr 4, 2024

stovak@T2GJHGYXTH-stovak terminus % ./terminus.phar site:create tom-new-site tom-new-site wordpress && curl -I https://dev-tom-new-site.pantheonsite.io 
 [notice] Creating a new site...
 [notice] Deploying CMS...
 [notice] Waiting for site availability...
 [notice] Your site has been created successfully!
HTTP/2 302 
cache-control: no-cache, must-revalidate, max-age=0
content-type: text/html; charset=UTF-8
expires: Wed, 11 Jan 1984 05:00:00 GMT
location: https://dev-tom-new-site.pantheonsite.io/wp-admin/install.php
server: nginx
strict-transport-security: max-age=300
x-pantheon-styx-hostname: styx-fe3-a-9764b5db6-5xxcp
x-redirect-by: WordPress
x-styx-req-id: 7d2cd649-f21b-11ee-83f7-c66ab8a72908
date: Thu, 04 Apr 2024 00:37:17 GMT
x-served-by: cache-chi-klot8100078-CHI, cache-bur-kbur8200128-BUR
x-cache: MISS, MISS
x-cache-hits: 0, 0
x-timer: S1712191037.199001,VS0,VE276
vary: Cookie, Cookie
x-robots-tag: noindex
age: 0
accept-ranges: bytes
via: 1.1 varnish, 1.1 varnish
content-length: 0

@stovak stovak requested a review from rwagner00 April 4, 2024 16:48
Copy link

@rwagner00 rwagner00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go again, more comments that I should have made the first time.

  1. Could we reduce the wait to 1s?
  2. Could we avoid sleeping altogether unless "wake" fails?

(Re implementation note for 2, I'd recommend moving the "while" conditional to the top of the loop, and put in a duplicate call to "wake" on the line before.)

@stovak stovak merged commit c3a564c into 3.x Apr 9, 2024
8 of 9 checks passed
@stovak stovak deleted the env-wake-after-site-create branch April 9, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants