-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOPS-2119 - Wait for a healthcheck before releasing the command #2564
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we go again, more comments that I should have made the first time.
- Could we reduce the wait to 1s?
- Could we avoid sleeping altogether unless "wake" fails?
(Re implementation note for 2, I'd recommend moving the "while" conditional to the top of the loop, and put in a duplicate call to "wake" on the line before.)
Tested with a local build against production PAPI. Seems to satisfy done-whens.