Added PHP 7.1 testing #1599
Merged
Added PHP 7.1 testing #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guess I'd better add 7.1 to the test matrix for annotated-command project & c. |
TeslaDethray
force-pushed
the
add/71_tests
branch
from
cc0b834 to
bd20189
Compare
| @@ -28,6 +30,30 @@ public function setUp() | |||
| */ | |||
| public function testConsole() | |||
| { | |||
| if (version_compare(PHP_VERSION, '7.1.0') < 0) { | |||
There was a problem hiding this comment.
Suggestion: use $this->markTestIncomplete("Console does not work on php7.1."); when PHP >= 7.1.0.
TeslaDethray
force-pushed
the
add/71_tests
branch
from
bd20189 to
e53cbd3
Compare
|
|
||
| public function testConsoleIncompatibleMessage() | ||
| { | ||
| $config = $this->getMockBuilder(TerminusConfig::class) |
There was a problem hiding this comment.
Suggestion: use $this->markTestIncomplete("Incompatible message only printed on php >= 7.1."); when PHP < 7.1.0. Then remove all of the $config test_mode_pass stuff and associated mocks.
There was a problem hiding this comment.
I'll use the incomplete for the first test, but this stays because I don't want my testing coverage to drop.
TeslaDethray
force-pushed
the
add/71_tests
branch
from
e53cbd3 to
0abe1d8
Compare
| ->disableOriginalConstructor() | ||
| ->getMock(); | ||
|
|
||
| $config->method('get') |
There was a problem hiding this comment.
Suggestion: Skip the $config mock when using php 7.1.
TeslaDethray
force-pushed
the
add/71_tests
branch
from
0abe1d8 to
d4837ed
Compare
TeslaDethray
force-pushed
the
add/71_tests
branch
from
d4837ed to
3b991b2
Compare
TeslaDethray
force-pushed
the
add/71_tests
branch
from
3b991b2 to
2f013c4
Compare
This was referenced Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using 7.1, so other people have to be, too.