Fixed SitesCommand#getSiteCreateOptions #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeslaDethray
force-pushed
the
fix/sitescommand_getsitecreateoptions
branch
3 times, most recently
from
389262a
to
09cd3a0
Compare
TeslaDethray
commented
Sep 29, 2016
| if (array_key_exists('name', $assoc_args)) { | ||
| // Deprecated but kept for backwards compatibility | ||
| $options['site_name'] = $assoc_args['name']; | ||
| } elseif (array_key_exists('site', $assoc_args)) { | ||
| $options['site_name'] = $assoc_args['site']; | ||
| } elseif (!is_null(Config::get('site'))) { | ||
| $options['site_name'] = Config::get('site'); | ||
| } elseif (!empty($site = Config::get('site'))) { |
There was a problem hiding this comment.
This line right here was the culprit. The change in config meant that we now have to check for empty rather than null.
TeslaDethray
changed the title
TeslaDethray
force-pushed
the
fix/sitescommand_getsitecreateoptions
branch
2 times, most recently
from
2357706
to
b112ebc
Compare
TeslaDethray
force-pushed
the
fix/sitescommand_getsitecreateoptions
branch
from
b112ebc
to
0e8ca1f
Compare
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't find the Jira issue for this. This was not caught by tests because you only enter this function if in interactive mode.