Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dependencies and tests that are vestigial of v1.x release #1209

Merged
merged 1 commit into from
Sep 19, 2016

Conversation

bensheldon
Copy link
Contributor

@bensheldon bensheldon commented Sep 16, 2016

This PR is part of branching off for the v0.13 branch in order to ensure that one can do composer require pantheon-systems/terminus:0.13.x. This backs out some of the changes that were introduced in the master branch on the road to v1 to ensure that the v0.13 tests/functionality work correctly.

Fixes #1207.

@bensheldon bensheldon changed the base branch from v0.13.x to 0.13.1 September 16, 2016 20:45
@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Coverage remained the same at 14.038% when pulling 69baa32 on fix_composer_require into 8dde1f0 on 0.13.1.

@TeslaDethray
Copy link
Contributor

What is this for? It's supposed to be in there. Is it causing some kind of trouble?

@greg-1-anderson
Copy link
Member

@TeslaDethray This breaks composer require installation mechanism that a lot of people use to pull down Terminus 0.13.0 for CI scripts, etc.

@TeslaDethray
Copy link
Contributor

TeslaDethray commented Sep 16, 2016

@greg-1-anderson Why? Is it a matter of minimum stability?

@greg-1-anderson
Copy link
Member

If you run composer require pantheon-systems/terminus:0.13.x in an empty directory, then Composer will create a new, empty composer.json file for you, and install Terminus inside of that. Terminus' composer.json and composer.lock end up in vendor/pantheon-systems/terminus; minimum stability and composer.lock are only respected in the top-level composer.json / composer.lock files.

Oddly enough, there is no way to run composer require and set the minimum stability in a single operation. You have to create your composer.json file, set the minimum stability there (either by editing it, or using a composer config command), and then you can composer require a package that has dependencies that require a lower-than-stable minimum stability.

@TeslaDethray
Copy link
Contributor

+1

@bensheldon bensheldon merged commit f108743 into 0.13.1 Sep 19, 2016
@bensheldon bensheldon deleted the fix_composer_require branch September 19, 2016 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants