-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AL-566 Change API host to terminus.pantheon.io #1180
Conversation
@bensheldon, thanks for your PR! By analyzing the blame information on this pull request, we identified @TeslaDethray, @ronan and @ari-gold to be potential reviewers |
I don't see why we need the dashboard host and protocol separated only to join them again later but since this is the established pattern I care probably 2/10 about that. +1 |
@@ -289,9 +289,9 @@ | |||
- | |||
request: | |||
method: POST | |||
url: 'https://dashboard.pantheon.io/api/authorize/machine-token' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sad that I missed erasing the machine token from this fixture.
+1 |
TERMINUS_PORT: 443 | ||
TERMINUS_PROTOCOL: 'https' | ||
TERMINUS_SSH_HOST: null | ||
|
||
# User Prompts | ||
DASHBOARD_HOST: 'dashboard.pantheon.io' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only used for the site dashboard
command ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it for the prompt that tells you where to go to create a machine token. I missed the site dashboard
command. I'll search again, but anywhere else it links to something on the Dashboard dashboard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for reference, I'm grepping through with config.*host
as there seems to be 2 styles for referencing config vars:
$config = Config::getAll();
$config['host']
And
Config::get('host')
Not sure if there is a style preference for one over the other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bensheldon OK. Cool. I think it's just site dashboard
and instructions for machine token generation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bensheldon The later is just a wrapper for the former. I would say that the later should be preferred.
a2d74fb
to
ad8a8de
Compare
ad8a8de
to
76eb94f
Compare
terminus.pantheon.io
hostDASHBOARD_HOST
constant for where the Dashboard URL is referenced in interface