Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminus should report more specific version information on dev-master #1660

Closed
greg-1-anderson opened this issue Mar 10, 2017 · 2 comments
Closed

Comments

@greg-1-anderson
Copy link
Member

Expected behavior

When running a development version of Terminus, the version should be reported as 1.1.1-dev (or similar)

Actual behavior

Terminus reports that it is version 1.1.1 for the stable version, and all dev versions after it, until the next stable tags.

Steps to reproduce the behavior

Install a dev version of Terminus (e.g. git clone, or composer require pantheon-systems/terminus:*) and run terminus version

This caused some confusion on #power-users, who thought that the 1.0.0 version was being re-tagged with new functionality.

@TeslaDethray
Copy link
Contributor

TeslaDethray commented Mar 13, 2017

I think this is a good idea. I've been similarly bamboozled.

To implement this, we would need to

  • Change the version number on Terminus' master branch to a.b.c-dev after the release is tagged
  • Add this as a step in our Terminus release guide
  • Also do for 0.x because why not

Do you concur @greg-1-anderson? If so, I'll implement.

@greg-1-anderson
Copy link
Member Author

Yes, that looks right.

Some form of version-string-manipulation-dance is what most projects do (remove -dev to tag a release, put it back when done).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants