Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks interesting but documentation is a bit light #15

Closed
toddheslin opened this issue Jul 2, 2017 · 3 comments
Closed

Looks interesting but documentation is a bit light #15

toddheslin opened this issue Jul 2, 2017 · 3 comments

Comments

@toddheslin
Copy link

This looks like a promising utility tool however I'm struggling to get it working. I suspect it was an internal project that was made public.

Is there any chance you can provide some insight (no pun intended) on which of the options are required and which are not?

I'm specifically getting the error:
TypeError: Object.keys(...).each is not a function
On this line: https://github.com/panoplyio/facebook-insight-stream/blob/master/index.js#L350, which is being called here https://github.com/panoplyio/facebook-insight-stream/blob/master/index.js#L153

When I change it to forEach() it works fine. Not sure if there was another part of the code where each was added onto the Object prototype.

When I got that working, it seems we have a parsing error:
SyntaxError: Unexpected token u in JSON at position 0 at FacebookInsightStream.parse (<anonymous>)

At this point I'm thinking that something has been omitted from the project that I might need to continue. I also had the case where npm install didn't actually install any of the dependences as they weren't listed in the package.json.

I'd love to see what this app can do!

@kensaggy
Copy link
Contributor

kensaggy commented Jul 3, 2017

Hi Todd, thanks for reporting the issue!

Indeed, like you suspected it was an internal project - so some dependencies were specified elsewhere.
We've updated the package.json to include the required dependencies as well updated the README to include an example options (See #16).

We've closed the issue for now as the dependency issue is resolved. If you're still having trouble feel free to open a new issue.

@toddheslin
Copy link
Author

Thanks @kensaggy. Looks like you did a good job - I rebased and followed your instructions. Everything is working perfect. Cheers!

@kensaggy
Copy link
Contributor

kensaggy commented Jul 4, 2017

Happy to hear! Actually the good job was done by @oshribin & @liorrozen - I just came for the update 😉

Let us know if you encounter any more issues and feel free to open PR if you want to add things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants