Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format key binding conflicts with default key binding on Mac. #75

Closed
ktnyt opened this issue Aug 22, 2021 · 1 comment
Closed

Format key binding conflicts with default key binding on Mac. #75

ktnyt opened this issue Aug 22, 2021 · 1 comment
Assignees
@panoply
Labels
Bug Something isn't working in the vscode extension

Comments

@ktnyt
Copy link

ktnyt commented Aug 22, 2021 •
edited
Loading

On a Mac, VSCode maps Cmd+Shift+L to Select All Occurrences of Find Match by default. This plugin overwrites Cmd+Shift+L to Liquid: Format Document which is very degenerative to the UX. Any plugin should not overwrite any of the default key bindings in VSCode. Please consider remapping to another key combination or add editorLangId == 'liquid' to the key binding condition.
@panoply panoply added the Bug Something isn't working in the vscode extension label Aug 22, 2021
@panoply panoply self-assigned this Feb 5, 2022
@panoply panoply added the 💧Liquify Features shipping in Liquify label Feb 5, 2022
@panoply panoply added this to the Liquify milestone Feb 11, 2022
@panoply panoply added v3.0.0 and removed 💧Liquify Features shipping in Liquify labels Sep 25, 2022
@panoply panoply removed this from the Liquify milestone Sep 25, 2022
@panoply
Copy link
Owner

panoply commented Sep 28, 2022

🚢 Shipped v3.0.0

Apologies on this one. No more key bindings.

@panoply panoply closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panoply panoply

Labels
Bug Something isn't working in the vscode extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ktnyt @panoply