Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help: closing braces of a liquid object #71

Closed
endepointe opened this issue Jun 1, 2021 · 2 comments
Closed

help: closing braces of a liquid object #71

endepointe opened this issue Jun 1, 2021 · 2 comments
Labels
Bug Something isn't working in the vscode extension 🎀 Æsthetic The issue pertains to Æsthetic

Comments

@endepointe
Copy link

endepointe commented Jun 1, 2021

after saving a .liquid file, the closing braces of a liquid object receive a space, like so:

{{some_object}}

to this:

{{some_object} }

This completely breaks the highlighting and produces a syntax error during live editing. I am not sure if this is a problem with vscode or the extension. I am not using any other extensions and have disabled the vscode settings for inserting spaces before and after braces.

any help is appreciated so I can move on. thank you

@panoply panoply added 💧Liquify Features shipping in Liquify PrettyDiff Bug labels Feb 5, 2022
@panoply panoply added this to the Liquify milestone Feb 11, 2022
@panoply panoply added v3.0.0 🎀 Æsthetic The issue pertains to Æsthetic and removed PrettyDiff Bug 💧Liquify Features shipping in Liquify labels Sep 25, 2022
@panoply panoply removed this from the Liquify milestone Sep 25, 2022
@panoply
Copy link
Owner

panoply commented Sep 28, 2022

This issue persists in latest release but will be handled upstream in Prettify (next patch release, ie: v3.0.1). For the time being, you can leverage inline ignores, eg:

<!-- @prettify-ignore-start -->
{{some_object}}
<!-- @prettify-ignore-end-->

You can track it here: https://github.com/panoply/prettify/issues/28

@panoply panoply added the Bug Something isn't working in the vscode extension label Sep 28, 2022
@panoply
Copy link
Owner

panoply commented Oct 27, 2022

Closing this as defect was addressed in previous releases

@panoply panoply closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working in the vscode extension 🎀 Æsthetic The issue pertains to Æsthetic
Projects
None yet
Development

No branches or pull requests

2 participants