Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension should only affect liquid tags #52

Closed
thecouchcoder opened this issue Jul 11, 2020 · 3 comments
Closed

Extension should only affect liquid tags #52

thecouchcoder opened this issue Jul 11, 2020 · 3 comments
Assignees
Labels
Bug Something isn't working in the vscode extension

Comments

@thecouchcoder
Copy link

I had to uninstall this plugin because it was causing syntax errors in my other projects which are written with Angular.

When I saved a .html file in Angular this extension was auto "correcting" syntax from routerLink to routerlink. This broke all links in my Angular project. This is just one example.

This extension should only be affecting liquid syntax, not all HTML syntax.

@panoply
Copy link
Owner

panoply commented Jul 11, 2020

Hey @aes421 – This version leverages Grammar injections which causes this issue. This has been addressed in the next release.

@panoply panoply added Bug Something isn't working in the vscode extension 💧Liquify Features shipping in Liquify labels Jul 11, 2020
@panoply panoply self-assigned this Aug 9, 2020
@panoply panoply added this to the Liquify milestone Aug 9, 2020
@duterte
Copy link

duterte commented Jan 3, 2021

I had to uninstall this plugin because it was causing syntax errors in my other projects which are written with Angular.

When I saved a .html file in Angular this extension was auto "correcting" syntax from routerLink to routerlink. This broke all links in my Angular project. This is just one example.

This extension should only be affecting liquid syntax, not all HTML syntax.

This extension also cause me lots of troubles, would you tell me your other way ?

@panoply panoply added v3.0.0 and removed 💧Liquify Features shipping in Liquify labels Sep 25, 2022
@panoply panoply removed this from the Liquify milestone Sep 25, 2022
@panoply
Copy link
Owner

panoply commented Sep 28, 2022

🚢 Shipped v3.0.0

Grammar injections are no longer applied in HTML. The language is now recognized as Liquid.

@panoply panoply closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working in the vscode extension
Projects
None yet
Development

No branches or pull requests

3 participants