Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments with Quotes Cause Strange HTML Injection #39

Closed
entozoon opened this issue Oct 22, 2019 · 3 comments
Closed

Comments with Quotes Cause Strange HTML Injection #39

entozoon opened this issue Oct 22, 2019 · 3 comments
Assignees
@panoply

Comments

@entozoon
Copy link

Input:

<html>
  <head>
    {% comment %}
     apostrophe's
    {% endcomment %}
  </head>
  <body>
  </body>
</html>

Formatted:

<html>
  <head>
    {% comment %}
     apostrophe's
    {% endcomment %}
  </head>
  <body>
  </body>
</html>
  </head>
</html>

And after every format it injects another..

  </head>
</html>

..every single time!

It appears to only happen when a comment contains an ' apostrophe or " quote, which is quite bizarre :)
@panoply panoply added PrettyDiff Bug 💧Liquify Features shipping in Liquify labels Oct 26, 2019
@panoply
Copy link
Owner

panoply commented Oct 27, 2019

Hey @entozoon I am aware of this and next release will fix this issue. It's actually a PrettyDiff issue but with version 2.4 nearing completion a lot of formatting conflicts and issues (like this) will be instead handled by the extensions parser opposed to PrettyDiff.

Some additional features to come in the next version will be a new and improved way to write comments which takes some minor inspiration from JS Docs.

@entozoon
Copy link
Author

Sounds amazing, great work @panoply . You rule :)

@panoply panoply self-assigned this Aug 9, 2020
@panoply panoply added this to the Liquify milestone Aug 9, 2020
@iBug iBug mentioned this issue Feb 16, 2021
Closed
@panoply panoply added v3.0.0 and removed PrettyDiff Bug 💧Liquify Features shipping in Liquify labels Sep 25, 2022
@panoply panoply removed this from the Liquify milestone Sep 25, 2022
@panoply
Copy link
Owner

panoply commented Sep 28, 2022

🚢 Shipped v3.0.0

@panoply panoply closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panoply panoply

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@entozoon @panoply