Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments #35

Closed
entozoon opened this issue Sep 11, 2019 · 2 comments
Closed

Comments #35

entozoon opened this issue Sep 11, 2019 · 2 comments
Assignees
Labels

Comments

@entozoon
Copy link

The Add line comment command, or similar, creates <!-- foo --> within .liquid files.
It might be preferable for it to create {% comment %} foo {% endcomment %} instead, if possible?

The benefit being that the liquid compiler will strip these out, so it is the best way to add comments to liquid files, typically

@panoply panoply added the 🙏🏻 Feature Request Feature Requests label Sep 11, 2019
@panoply
Copy link
Owner

panoply commented Sep 11, 2019

So currently, PrettyDiff handles this rule but internally it's parser (sparser) has some trouble with Liquid comments. Providing support for this would require taking control of comment formatting away from Sparser and creating an internal solution which I agree would be worth applying.

I will looking into this post v2.4.0.

@panoply panoply added the 💧Liquify Features shipping in Liquify label Oct 11, 2019
@panoply panoply self-assigned this Aug 9, 2020
@panoply panoply added this to the Liquify milestone Aug 9, 2020
@panoply panoply added the v3.0.0 label Sep 16, 2022
@panoply panoply removed the 💧Liquify Features shipping in Liquify label Sep 25, 2022
@panoply panoply removed this from the Liquify milestone Sep 25, 2022
@panoply
Copy link
Owner

panoply commented Sep 28, 2022

🚢 Shipped v3.0.0

@panoply panoply closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants