Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New auto-format on save is causing issues #141

Closed
customerhub opened this issue Dec 22, 2022 · 2 comments
Closed

New auto-format on save is causing issues #141

customerhub opened this issue Dec 22, 2022 · 2 comments
Labels
✖️ Boycott This will not be implemented or the issue is lacking logic 💬 Question Further information is requested or insight to be given

Comments

@customerhub
Copy link

customerhub commented Dec 22, 2022

I format my liquid very specifically to optimize size for Shopify app extensions - this new feature you added by default that formats on save, is a nightmare for us - it is messing up all our optimized formatting.

I tried toggling it off (with that little liquid icon at the bottom) but it continues to format on save and undo my changes, even after restart.

Can you please let me know what the killswitch is for this thing? and how exactly I toggle it? (ie is it a Command Pallette command?).

I will be uninstalling this one until you advise - and just a recomentation - do not auto-enable such features by default that mess with code format so aggressivlely, alert us to the feature and how we can enable if we choose too.

@panoply
Copy link
Owner

panoply commented Dec 22, 2022

I format my liquid very specifically to optimize size for Shopify app extensions - this new feature you added by default that formats on save, is a nightmare for us - it is messing up all our optimized formatting

As per the documentation Settings Default Formatter you can prevent formatting on save as follows:

{
   "[liquid]": {
      "editor.formatOnSave": false
   }
}
  • and just a recomentation - do not auto-enable such features by default that mess with code format so aggressivlely, alert us to the feature and how we can enable if we choose too.

Just a recommendation, maybe take the time to read about vscode how to control the editor. As Per #132 the next release addresses the defaults applied.

@panoply panoply added 💬 Question Further information is requested or insight to be given ✖️ Boycott This will not be implemented or the issue is lacking logic labels Dec 26, 2022
@panoply
Copy link
Owner

panoply commented Dec 26, 2022

Closing this, see #142 for further details.

@panoply panoply closed this as completed Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✖️ Boycott This will not be implemented or the issue is lacking logic 💬 Question Further information is requested or insight to be given
Projects
None yet
Development

No branches or pull requests

2 participants