Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back an example recipe to start from #185

Open
rabernat opened this issue Sep 23, 2022 · 1 comment
Open

Bring back an example recipe to start from #185

rabernat opened this issue Sep 23, 2022 · 1 comment

Comments

@rabernat
Copy link
Contributor

This repo now has no example template to start from

@cisaacstern
Copy link
Member

cisaacstern commented Sep 23, 2022

Noting that the pangeo-forge GitHub App will automatically delete any subdirectories merged to recipes/, so once a PR for this example is ready to go, an organization admin will need to temporarily suspend the app installation before merge, here:

https://github.com/organizations/pangeo-forge/settings/installations/28971742

Screen Shot 2022-09-23 at 10 46 40 AM

Of course, the GitHub App installation will need to be reinstated immediately after the PR is merged.

Also, it's probably worth considering how this example will relate to the Sandbox's example files (which have likely gone somewhat stale at this point). Potentially the Sandbox example files could be removed (I'm not certain that they are really used). But learning from the example there, we'll probably want some type of automated testing associated with the example here, to ensure that the meta.yaml remains in-spec (and references the latest release of pangeo-forge-recipes), and that the recipe.py is compatible with the latest release of pangeo-forge-recipes. The former requirement points to another issue, which is that we need a JSON Schema for meta.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants