Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecate pandas.tests #47738

Closed
wants to merge 4 commits into from
Closed

DEPR: deprecate pandas.tests #47738

wants to merge 4 commits into from

Conversation

twoertwein
Copy link
Member

Not sure how to test this. All of the following imports trigger the warning (DeprecationWarning is by default not enabled, which hopefully doesn't spam the CI):

python -W default -c "from pandas import tests"
python -W default -c "from pandas.tests.frame import common"
python -W default -c "import pandas.tests.frame.common"

@pep8speaks
Copy link

pep8speaks commented Jul 15, 2022

Hello @twoertwein! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-07-16 18:27:17 UTC

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be tested by running that python command in a subprocess and inspecting stdout?

@twoertwein
Copy link
Member Author

Could be tested by running that python command in a subprocess and inspecting stdout?

I added such a test case but for some reason, it doesn't trigger the warning. I don't know why.

@twoertwein twoertwein closed this Jul 18, 2022
@twoertwein twoertwein deleted the tests branch September 10, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST/TYP: make pandas/tests private
3 participants