ENH: Map pandas integer to optimal SQLAlchemy integer type (GH35076) #38548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinashpancham
force-pushed
the
GH35076
branch
from
d3ad26e
to
b0372fa
Compare
|
Note for future reference: On windows numpy 1.16 |
mroeschke
reviewed
Dec 20, 2020
mroeschke
reviewed
Dec 20, 2020
doc/source/whatsnew/v1.3.0.rst
Outdated
| @@ -244,6 +244,8 @@ I/O | |||
| - Allow custom error values for parse_dates argument of :func:`read_sql`, :func:`read_sql_query` and :func:`read_sql_table` (:issue:`35185`) | |||
| - Bug in :func:`to_hdf` raising ``KeyError`` when trying to apply | |||
| for subclasses of ``DataFrame`` or ``Series`` (:issue:`33748`). | |||
| - Bug in :func:`_sqlalchemy_type` that mapped pandas integer types to non-optimal SQLAlchemy integer types (:issue:`35076`) | |||
There was a problem hiding this comment.
This should be an enhancement and should just mention that impacts to_sql
There was a problem hiding this comment.
Thanks, updated it
avinashpancham
changed the title
mroeschke
approved these changes
Dec 21, 2020
|
Mind fixing the merge conflict @avinashpancham? |
jreback
approved these changes
Dec 23, 2020
|
Sure, updated it. |
|
@mroeschke CI is greenish, only Travis gives an error due to other reasons. |
|
Thanks @avinashpancham |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
…andas-dev#38548) * BUG: Map pandas integer to optimal SQLAlchemy integer type (GH35076) * Add conditional for default 32/64 bit integer size * Check precision of int dtype * Add whatsnew entry * Update whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff