BUG: allow None as name in multi-index during join #59546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiaslindgren
changed the title
rhshadrach
requested changes
Aug 25, 2024
There was a problem hiding this comment.
This is looking good to me, but we were explicit about not allowing None in the past and I'm not sure why. Traced it back to:
- issue: Merge on single level of MultiIndex #3662
- commit: dd79e55
Don't see any discussion about None. Can you take a look @mroeschke
doc/source/whatsnew/v3.0.0.rst
Outdated
| @@ -28,6 +28,7 @@ enhancement2 | |||
|
|
|||
| Other enhancements | |||
| ^^^^^^^^^^^^^^^^^^ | |||
| - :attr:`MultiIndex.names` containing ``None`` no longer throws ``AssertionError`` during join (:issue:`58721`) | |||
There was a problem hiding this comment.
Can you move the note to the Reshaping section of bugfixes.
rhshadrach
added
Bug
Reshaping
matiaslindgren
requested review from
WillAyd,
noatamir and
mroeschke
as code owners
matiaslindgren
force-pushed
the
fix-58721
branch
from
9bbf1d8 to
abb0976
Compare
|
Automatic codeowner review requests were unintended, sorry. I accidentally pushed commits from my fork to this branch and that touched files unrelated to this PR. Force-pushed them away. |
mroeschke
reviewed
Aug 26, 2024
Co-authored-by: Matthew Roeschke <[email protected]>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mroeschke
approved these changes
Aug 26, 2024
|
Thanks @matiaslindgren |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Another possible fix is to throw if
MultiIndex.namescontainsNone.The exception message could say something like "empty index names must be empty strings, not None".