Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Enhancement for spss kwargs #56434

Merged
merged 51 commits into from
Aug 27, 2024

Conversation

astronights
Copy link
Contributor

@astronights astronights commented Dec 10, 2023

@astronights astronights changed the title Bug fix for spss kwargs BUG: Bug fix for spss kwargs Dec 10, 2023
Copy link

@tinrobot2000 tinrobot2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Looks good to me, just added some minor comments.

pandas/io/spss.py Outdated Show resolved Hide resolved
pandas/io/spss.py Outdated Show resolved Hide resolved
pandas/tests/io/test_spss.py Outdated Show resolved Hide resolved
@datapythonista datapythonista added the IO Data IO issues that don't fit into a more specific label label Jan 15, 2024
pandas/io/spss.py Outdated Show resolved Hide resolved
pandas/io/spss.py Outdated Show resolved Hide resolved
pandas/io/spss.py Outdated Show resolved Hide resolved
pandas/io/spss.py Outdated Show resolved Hide resolved
@astronights astronights requested a review from mroeschke January 29, 2024 08:00
@astronights
Copy link
Contributor Author

Can we merge if all is good?

Copy link
Contributor

github-actions bot commented Mar 5, 2024

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Mar 5, 2024
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Aug 26, 2024
@astronights
Copy link
Contributor Author

Hi, I've updated the PR with the main. You could reopen this.

@mroeschke mroeschke reopened this Aug 26, 2024
@astronights
Copy link
Contributor Author

astronights commented Aug 26, 2024

Hi @mroeschke , the build is done. Can we merge?

@mroeschke mroeschke modified the milestones: 2.3, 3.0 Aug 27, 2024
@mroeschke mroeschke merged commit c375533 into pandas-dev:main Aug 27, 2024
47 checks passed
@mroeschke
Copy link
Member

Thanks @astronights

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Data IO issues that don't fit into a more specific label Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add kwargs to pandas.read_spss so that pyreadstat keyword args can be used
6 participants