Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: handling of categorical with dropna=False in Grouping._codes_and_uniques #46909

Closed
rhshadrach opened this issue Apr 30, 2022 · 2 comments · Fixed by #48702
Closed

CLN: handling of categorical with dropna=False in Grouping._codes_and_uniques #46909

rhshadrach opened this issue Apr 30, 2022 · 2 comments · Fixed by #48702
Assignees
Labels
Categorical Categorical Data Type Clean Groupby

Comments

@rhshadrach
Copy link
Member

#46601 fixed using categorical with dropna=False in groupby by avoiding the categorical-specific logic in Grouping._codes_and_uniques. While this allowed for correct results, it seems better to fix the categorical-specific logic to handle dropna=False.

Avoiding the categorical-specific logic may also have some performance impact, I plan to benchmark it shortly.

@phofl
Copy link
Member

phofl commented Sep 19, 2022

@rhshadrach Is there a quick fix that we can backport? This caused a couple of regressions it seems

@rhshadrach
Copy link
Member Author

Thanks - ref: #48645. I'm looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Clean Groupby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants