-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Enable PEP 517 #39415
Comments
I will recommend switching to setuptools_scm how it was done in matplotlib matplotlib/matplotlib#18971 |
We hope to get the complete git commit hash, but not sure how to do that using |
We can retrieve full commit hash, using setuptools-scm with the following config: [tool.setuptools_scm]
git_describe_command = [
"git",
"describe",
"--dirty",
"--tags",
"--abbrev=40",
"--long",
"--match",
"*[0-9]*",
] This will overide the default git describe command used by setuptools-scm to get the full (40 digits long hex hash). |
@jules-ch Thanks for this. I posted the link to your comment in the corresponding And in the meantime, a PR is welcome if you want to give this a try^^ |
It is worth noting that as of v0.24 Lines 10 to 12 in 75429df
|
closed by #49115 |
After #38852, we could enable PEP 517 by modifying PATH in setup.py or use non-vendored versioneer. See python-versioneer/python-versioneer#193 for details.
The text was updated successfully, but these errors were encountered: