Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISC: use of typing.cast #32785

Closed
simonjayhawkins opened this issue Mar 17, 2020 · 3 comments
Closed

DISC: use of typing.cast #32785

simonjayhawkins opened this issue Mar 17, 2020 · 3 comments
Labels
Needs Discussion Requires discussion from core team before further action Typing type annotations, mypy/pyright type checking

Comments

@simonjayhawkins
Copy link
Member

placeholder to address #32730 (comment)
@simonjayhawkins simonjayhawkins added Needs Discussion Requires discussion from core team before further action Typing type annotations, mypy/pyright type checking labels Mar 17, 2020
@simonjayhawkins simonjayhawkins mentioned this issue Mar 19, 2020
Merged
This was referenced Apr 10, 2020
Merged
Merged
@simonjayhawkins
Copy link
Member Author

@jorisvandenbossche @WillAyd @jbrockmendel to avoid having similar conversations in separate PRs, we can xref back to this issue.

@simonjayhawkins simonjayhawkins mentioned this issue Apr 22, 2020
Merged
@jbrockmendel
Copy link
Member

Is this actionable/closeable? I think I've seen you use typing.cast, and I'm pretty happy deferring to you on typing-related issues.

@jbrockmendel jbrockmendel added the Closing Candidate May be closeable, needs more eyeballs label Sep 25, 2020
@simonjayhawkins
Copy link
Member Author

We have has a few regressions caused by using asserts. This is a double edge sword, since we at least identify where our assumptions on types are incorrect.

This was a placeholder for discussion, to avoid the discussion in separate PRs.

but OK with closing for now.

@simonjayhawkins simonjayhawkins removed the Closing Candidate May be closeable, needs more eyeballs label Sep 26, 2020
@simonjayhawkins simonjayhawkins mentioned this issue Oct 26, 2020
Closed
@simonjayhawkins simonjayhawkins mentioned this issue Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Discussion Requires discussion from core team before further action Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrockmendel @simonjayhawkins