Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appender Causing MyPy Issues #26629

Closed
WillAyd opened this issue Jun 3, 2019 · 3 comments
Closed

Appender Causing MyPy Issues #26629

WillAyd opened this issue Jun 3, 2019 · 3 comments
Labels
Typing type annotations, mypy/pyright type checking

Comments

@WillAyd
Copy link
Member

WillAyd commented Jun 3, 2019

ref #26414 (comment) it appears that mypy and the Appender may not be playing nice together. A solution to this may be tucked away in python/mypy#3157
@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Jun 3, 2019
@WillAyd WillAyd added this to the Contributions Welcome milestone Jun 3, 2019
@WillAyd WillAyd mentioned this issue Jun 3, 2019
Merged
4 tasks
@jbrockmendel
Copy link
Member

Whats the win condition here? i.e. how can i check whether this is fixed?

@WillAyd
Copy link
Member Author

WillAyd commented Nov 8, 2019

Closing this in favor of #27404 - there is more details therein

@WillAyd WillAyd closed this as completed Nov 8, 2019
@WillAyd
Copy link
Member Author

WillAyd commented Nov 8, 2019

Though should have been solved by #28128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WillAyd @jbrockmendel