Fix type annotations for pandas.core.indexes.base

[vaibhavhrt]

Part of #25882

Current errors are:

pandas\core\indexes\base.py:9: error: Module 'pandas._libs' has no attribute 'join'

[vaibhavhrt]

The line with the error is:

from pandas._libs import (
    algos as libalgos, index as libindex, join as libjoin, lib)

A join.pyx file does exists in the _libs directory but mypy is still giving error. The other imports algos, index and lib are also .pyx file but there is no error for them.
@WillAyd some help here please. Do we need a .pyi file?

[WillAyd]

You can just move the join as alias to a separate line - Mypy doesn’t seem to like that all being on one line and we’ve done that elsewhere

[vaibhavhrt]

@WillAyd you mean like this? 👇

from pandas._libs import (
    algos as libalgos, index as libindex, lib)
from pandas._libs import join as libjoin

[vaibhavhrt]

No matter how I import it makes no difference. Still same error.

[WillAyd]

That’s right

…

Sent from my iPhone

On May 13, 2019, at 6:46 AM, Vaibhav Vishal ***@***.***> wrote: @WillAyd you mean like this? 👇 from pandas._libs import ( algos as libalgos, index as libindex, lib) from pandas._libs import join as libjoin — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[gwrome]

Try import pandas._libs.join as libjoin.

[vaibhavhrt]

@gwrome thanks, it works.