Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD/CI: wheel building is failing #25867

Closed
jreback opened this issue Mar 25, 2019 · 3 comments · Fixed by #25874
Closed

BLD/CI: wheel building is failing #25867

jreback opened this issue Mar 25, 2019 · 3 comments · Fixed by #25874
Labels
Build Library building on various platforms CI Continuous Integration
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Mar 25, 2019

I think some PRs yesterday broke pandas-wheels: https://travis-ci.org/MacPython/pandas-wheels/jobs/510798584, likely all the same issues: https://travis-ci.org/MacPython/pandas-wheels/builds/510798582

if someone can you do a quick PR to update (not easy to test unfort).

______________________ TestFactorize.test_complex_sorting ______________________
[gw0] linux -- Python 3.6.6 /venv/bin/python
self = <pandas.tests.test_algos.TestFactorize object at 0x7f7cbf173710>
    def test_complex_sorting(self):
        # gh 12666 - check no segfault
        x17 = np.array([complex(i) for i in range(17)], dtype=object)
    
        msg = (r"unorderable types: {0} [<>] {0}".format(r"complex\(\)")
               if _np_version_under1p14 else
               r"'[<>]' not supported between instances of {0} and {0}".format(
                   "'complex'")
               )
        with pytest.raises(TypeError, match=msg):
>           algos.factorize(x17[::-1], sort=True)
E           AssertionError: Pattern 'unorderable types: complex\(\) [<>] complex\(\)' not found in ''>' not supported between instances of 'complex' and 'complex''
/venv/lib/python3.6/site-packages/pandas/tests/test_algos.py:237: AssertionError
_________________________ TestSafeSort.test_unsortable _________________________
[gw0] linux -- Python 3.6.6 /venv/bin/python
self = <pandas.tests.test_sorting.TestSafeSort object at 0x7f7cbecbce48>
    def test_unsortable(self):
        # GH 13714
        arr = np.array([1, 2, datetime.now(), 0, 3], dtype=object)
        msg = (r"unorderable types: ({0} [<>] {1}|{1} [<>] {0})".format(
                   r"int\(\)", r"datetime\.datetime\(\)")  # noqa: E126
               if _np_version_under1p14 else
               (r"'[<>]' not supported between instances of "
                r"({0} and {1}|{1} and {0})").format(
                    "'int'", r"'datetime\.datetime'")
               )
        with pytest.raises(TypeError, match=msg):
>           safe_sort(arr)
E           AssertionError: Pattern 'unorderable types: (int\(\) [<>] datetime\.datetime\(\)|datetime\.datetime\(\) [<>] int\(\))' not found in ''>' not supported between instances of 'int' and 'datetime.datetime''
@jreback jreback added Build Library building on various platforms CI Continuous Integration labels Mar 25, 2019
@jreback jreback added this to the 0.25.0 milestone Mar 25, 2019
@jreback
Copy link
Contributor Author

jreback commented Mar 25, 2019

note I just restarted these to account for the latest changes in master.

@WillAyd
Copy link
Member

WillAyd commented Mar 26, 2019

Hmm those error messages were touched as part of #25752 right?

cc @h-vetinari

@h-vetinari
Copy link
Contributor

@WillAyd
Thanks for the ping, will respond in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants