Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go modules; upgrade deps for Terraform v0.12 #16

Merged
merged 4 commits into from
Aug 2, 2019
Merged

Use Go modules; upgrade deps for Terraform v0.12 #16

merged 4 commits into from
Aug 2, 2019

Conversation

andreykaipov
Copy link
Contributor

First off thank you @mbag and @splashx for unarchiving this provider 😄

Here's the steps I took:

go mod init
go clean -modcache
go get github.com/hashicorp/[email protected]
go mod tidy
go mod vendor

After building and moving the provider to one of the discoverable plugin locations, I was able to get it working with Terraform v0.12.

@ghost ghost added the size/XXL label Jun 27, 2019
@andreykaipov
Copy link
Contributor Author

Also tested this with Terraform v0.11 and it still works!

@mbag
Copy link
Collaborator

mbag commented Jul 1, 2019

hi @andreykaipov thanks for the PR,

I'm still waiting for an access to Hashicorp's Terraform TeamCity testing environment. Even though this repository has Travis tests, the TF TeamCity tests will be decisive. I'll merge/get back to you regarding changes, once I know what kind of tests are required by TF to consider provider migrated.

In the mean time, it was my mistake not creating PR with test fixes, can you create independent PR, instead of it being part of this PR? I'm referring to this commit: hashicorp@4a65a01

Once again thank you for taking time to work on PowerDNS provider.

@loksonarius
Copy link
Contributor

I like this ❤️

@andreykaipov
Copy link
Contributor Author

Hi @mbag - sounds good to me! Looking forward to hearing how that goes.

I've removed the test fix commit from this PR and opened https://github.com/terraform-providers/terraform-provider-powerdns/pull/17 in its place.

@tombuildsstuff tombuildsstuff self-requested a review July 9, 2019 10:44
@mbag mbag merged commit 51fbf7d into pan-net:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants