Deprecate merged extensions

[davidism]

autoescape and with have been in the standard compiler for years now. The extensions do nothing. Make them issue a deprecation warning, for removal in 3.1.

[septatrix]

I think it may be better to add the deprecation warning in a new minor 2.x release and remove them in 3.0

[FawziyahAlebiosu]

@davidism for clarification, would this warning be printed when this (

jinja/src/jinja2/utils.py

Line 526 in 0a37031

def autoescape(template_name):

) is called?

[davidism]

This warning would be for the extensions, that function is part of the built-in support that superseded the extensions.

The extensions are in ext.py, you'd want to override the __init__ method for WithExtension, and AutoEscapeExtension to show a deprecation warning.

[FawziyahAlebiosu]

@davidism Because those two classes take in this init method here:

jinja/src/jinja2/ext.py

Line 73 in 3915eb5

def __init__(self, environment):

would it be more efficient to add the warning to THAT method, or should I create an init method for those two classes, and use THAT to override and show the warning?

[davidism]

Only those two extensions are deprecated, not all extensions, so you shouldn't add the deprecation to the base class.

[FawziyahAlebiosu]

that makes sense to me. Is it okay to begin working on this?

[davidism]

Sure!