Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repr and add tests #1296

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Fix repr and add tests #1296

merged 4 commits into from
Jan 15, 2024

Conversation

pamelafox
Copy link
Contributor

This PR adds test for SQLAlchemy's repr and fixes its handling of the no default engine scenario.

This fix assumes we want engine() to continue to throw a KeyError in that scenario (i.e. all handling is in repr itself).

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@pamelafox pamelafox changed the base branch from main to 3.1.x December 28, 2023 04:48
@pamelafox pamelafox merged commit fec440f into 3.1.x Jan 15, 2024
8 checks passed
@pamelafox pamelafox deleted the reprfix branch January 15, 2024 15:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidism davidism davidism approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLAlchemy.__repr__ raises KeyError when the default engine is not set.
2 participants
@pamelafox @davidism