Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need of fragments introduced by the source line number feature #23

Open
tbatchelli opened this issue Feb 19, 2013 · 1 comment

Comments

@tbatchelli
Copy link
Member

The introduction of source line numbers in the generated script created a new issue, scripts are not composable outside of stevedore (e.g. https://github.com/pallet/pallet/blob/develop/src/pallet/crate/etc_hosts.clj#L115 where the file name is generated via stevedore).

The problem is that the way comments work in bash make this kind of composition impossible, as anything after the comment is ignored. Since now stevedore adds the line numbers as comments, we needed a way to generate scripts without these line numbers.

A better solution could be to have stevedore proactively sanitize these 'included' scripts by removing comments. This way, we could still regular stevedore scripts without needing the special case of 'fragments'

@tbatchelli
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant