-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serial_test_derive syn dependency to syn 2 #95
Comments
This won't help until tokio-macros upgrades. See https://github.com/tokio-rs/tokio/blob/master/tokio-macros/Cargo.toml#L27 |
This is now unblocked as tokio-macros has upgraded 🙂. No pressure to rush on this, just a friendly unblocking notification. |
One thing I noticed in other repos is that syn 2's MSRV is
Updating to syn 2 will require a major version bump. |
I'm up for giving the update a go if ya want the help @palfrey |
No, that's fine. The upgrade here is pretty simple, but I want to write some specific docs about the MSRV bump as I'm planning on bumping it all the way to 1.68.2. This is more than compilation requires right now, but mostly for a future-proofing perspective i.e. reducing the odds of having to release a 3.x when something else bumps. |
@CosmicHorrorDev If you felt like helping this path though, actix-macros needs that work as well but that's a much larger piece. Technically we rely on that similarly to tokio, but given they're both just test dependencies I'm going to do the upgrade here now for the core and fix actix when that's available without needing to do a new release. |
#96 fixes this |
Released as 2.0.0 |
Syn 2 was released recently and some crates, e.g. thiserror, are already migrated. To reduce clean compile times, should upgrade dependency to syn 2.
The text was updated successfully, but these errors were encountered: