Checked in built UMD bundles out-of-date with source code

[mightyiam]

Last dist rebuild seems to be 3ed3a2a.

Commits since:

f49c793
f8774a9
0c7f9dd
69294d8
5035aed
f54fb9b
8edc47f
0db9e8b
5b5576f
d9ff8da
3ae871d
0881343
5a3ae5e
c185445
c2e66b5
7ff8d13
dcdde2e
5fd1cec
7c9a7ac
35796cb
52cd3ee
a907828
8b66f53
21511f3
32a0ff3
9053f07
4d07d0c
98e1dc1
6c5549b
809caa1
3dbf18e
4b19aeb
b39ada9
4243938
808944d
54b6b45
6e86a5a
f307db4
3f85807
98e9cdb
e77ecfc
79098d3
179940d
9033c58
dcbc1e1
f2b83d1
529b46c
64c9bfe
3e87660
d3d4f08
ae3703d
47f3afd
7e09d27
66f2e18
1ca1584
b40ab1c
63a0c04
8787d60
de104c0
dcce583
4e25f86
1f399d6
a0518b9
ff59494
e4efc1d
256e35f
fab31f3
2b56e24
9a68a1e
0a3bc6f
5c0f3db
d0cabc9
db3100d
81da0c1
f66f919
425a6b2
3b04714
29b2829
695da13
3c0f50a
6a632c2
e034e96
80603c2
2e73a92
a34ffff
665d9d3
f7c3b0c
276f78d
102fb59
00129c2
953a326
0095162
4455e73
9378715
1c4bfb7
3fe95cc
d0ddf15
053a387
37a522d
efda964
b9f2db2
b4d69ae
1a8892c
fd30295
0061332
730f6f8
d7a38d7
093367e
584f2c5
3438b74
fb04f62
410d2b3
2ab6f3d

Since the releases since the last build seem to be patch-only, it suggest that a rebuild-commit would be a PATCH version.

I could investigate further and attempt to fix but I really suggest #481.

[cowpig]

Hey @mightyiam -- I'm trying to use unpkg to import snabbdom in a project with no build step. However, after adding:

import { init } from "https://unpkg.com/snabbdom"
import { h } from "https://unpkg.com/snabbdom/h"

It looks like my browser is fetching source files that are not compiled. Accessing those files in my browser directly confirms they're raw source files.

Looks like Unpkg expects a UMD build -- is this issue the cause? Because I would expect them to be old, but still compiled, files.

[mightyiam]

@cowpig

https://unpkg.com/browse/[email protected]/dist/snabbdom.js
https://unpkg.com/browse/[email protected]/dist/h.js

Open this with your browser for a list:
https://unpkg.com/browse/[email protected]/dist/

[cowpig]

Ah, thank you!!

[mightyiam]

So, we have at least one user UMD user who went as far as commenting on an issue. Since it seems that bundling as UMD provides additional value through unpkg, I feel that we should provide that. I'll make a PR. I'm looking into bundling with webpack.

[kuraga]

But let's merge #553 anyway...

[mightyiam]

@kuraga I wouldn't like to do that, be cause it would seem to me like a regression and also a commit with a breaking change log entry. But I will use that commit in the PR that introduces UMD bundling with webpack.

[kuraga]

@mightyiam I meant "let's untrack /dist directory from VCS" anyway...

[mightyiam]

I would like to do that, indeed. But here is a user with a use case. Is there a reasonable alternative to unpkg?

For some of the use cases, I just created a template on CodeSandbox. Perhaps we could link there in the readme.

But the exact functionality that we're looking for is something like unpkg but that does not require UMD bundles. It can create such bundles itself. Oh, I just found one. How about this:

https://bundle.run/[email protected]/es/snabbdom.js

@cowpig, could you please help us out here? If you could try out the above bundle.run service for your app and tell us whether that works out for you?

[kuraga]

@mightyiam ,

but that does not require UMD bundles

So do you propose to not have UMD bundles even in NPM package? Or the same but not only for UMD bundles?

[mightyiam]

@kuraga if bundle.run serves the same purpose while we don't have to make UMD bundles, I'd be happy to not provide them.