Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Rename src/test folder to fix #3072 #3081

Merged
merged 2 commits into from
Jul 28, 2017
Merged

Rename src/test folder to fix #3072 #3081

merged 2 commits into from
Jul 28, 2017

Conversation

aleung
Copy link
Contributor

@aleung aleung commented Jul 28, 2017

PR checklist

Overview of change:

Rename src/test folder to src/verify and update all places where import it.

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @aleung! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@aleung aleung mentioned this pull request Jul 28, 2017
4 tasks
Copy link
Contributor

@ajafff ajafff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Since noone should import these files directly, it's safe to consider this a bugfix.

If it really breaks someone, we could add back the renamed files as a thin wrapper that just exports everything from the new file.

@ajafff ajafff merged commit 42ff133 into palantir:master Jul 28, 2017
@ajafff
Copy link
Contributor

ajafff commented Jul 28, 2017

Thanks @aleung

HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants