Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fixed casing of names, added "more" link #2998

Merged
merged 2 commits into from
Jul 6, 2017

Conversation

304NotModified
Copy link
Contributor

@304NotModified 304NotModified commented Jul 5, 2017

PR checklist

  • Documentation update

Overview of change:

Changed readme:

  • Added more link
  • Fixed casing of names.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add this to the docs website instead? https://palantir.github.io/tslint/usage/third-party-tools/

@304NotModified
Copy link
Contributor Author

Sure, is it OK to link the "more" then to https://palantir.github.io/tslint/usage/third-party-tools/? (as we now have 2 lists?)

@304NotModified
Copy link
Contributor Author

and is the fix casing of names OK?

@304NotModified
Copy link
Contributor Author

304NotModified commented Jul 6, 2017

@ajafff
Copy link
Contributor

ajafff commented Jul 6, 2017

The change in casing seems good to me.

is it OK to link the "more" then to https://palantir.github.io/tslint/usage/third-party-tools/?

Makes sense IMO

The file you need to change to update the website is https://github.com/palantir/tslint/blob/master/docs/usage/third-party-tools/index.md on master

@adidahiya
Copy link
Contributor

  • casing fix is good
  • link to "more" is good
  • yes you need to edit the docs source on master
    • then, separately make a gh-pages PR with the compiled docs (npm run docs, copy the changes to a new branch off gh-pages)... maintainers will eventually do this for you when releases are made

@304NotModified 304NotModified changed the title Added SonarQube plugin to readme Fixed casing of names, added "more" link Jul 6, 2017
@304NotModified
Copy link
Contributor Author

Updated it, I assume squash is not needed as Github can Squash now :)

@adidahiya adidahiya merged commit 4b73647 into palantir:master Jul 6, 2017
HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants