You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add a new option disallow-object-reference to Rule: ban
Motivation
Rule: ban only catches function calls. We stumbled upon a need of catching specific object reference, which is 'self' in our case.
Without local declaration, self refers to window.self. While removing an old convention, var self = this;, we noticed it's prone to overlook because the compiler doesn't throw error because self is still valid.
The text was updated successfully, but these errors were encountered:
Suggestion
Add a new option
disallow-object-reference
to Rule: banMotivation
Rule: ban only catches function calls. We stumbled upon a need of catching specific object reference, which is 'self' in our case.
Without local declaration,
self
refers towindow.self
. While removing an old convention,var self = this;
, we noticed it's prone to overlook because the compiler doesn't throw error becauseself
is still valid.The text was updated successfully, but these errors were encountered: